deps: bump to controller-runtime v0.2.0, kubernetes-1.14.1, and helm v2.14.1 by estroz · Pull Request #1512 · operator-framework/operator-sdk

estroz · 2019-06-03T17:30:13Z

Description of the change: bump controller-runtime to v0.2.0 and helm to 2.14.0, both of which depend on kubernetes-1.14.x dependencies.

Motivation for the change: from #1388:

Address the commit kubernetes-sigs/controller-runtime@fc804a4

How to make sure that the operator will only watch a List of namespaces? #1386

Allow users to watch/cache N namespaces as follows.
        // Create a new Cmd to provide shared dependencies and start components
  mgr, err := manager.New(cfg, manager.Options{
  	NewCache: cache.MultiNamespacedCacheBuilder(namespaces),
  })

estroz · 2019-06-06T00:39:30Z

 	"k8s.io/apimachinery/pkg/runtime/schema"
 	"k8s.io/apimachinery/pkg/runtime/serializer"
-	"k8s.io/client-go/discovery/cached"
+	cached "k8s.io/client-go/discovery/cached"


The compiler throws errors if there's no build identifier.

estroz · 2019-06-06T00:41:47Z

/cc @joelanford @hasbro17 @AlexNPavel @lilic @shawn-hurley @theishshah
@camilamacedo86

PTAL

estroz · 2019-06-06T17:28:00Z

/test marker

lilic · 2019-06-07T10:31:38Z

@camilamacedo86 @estroz Whichever PR lands in, we need a migration doc, I guess we can do this in a parallel PR for ease of reviewing?

joelanford · 2019-06-07T19:13:15Z

Also, what did we decide on what to do with this PR? Sit on it? Merge it into a separate branch? Merge it into master? Right now looks like it's targetting master.

estroz · 2019-06-07T20:17:51Z

@joelanford IIRC we agreed to merge with master because the original controller-runtime refactor was a much larger change than v0.1.x -> v0.2.x.

joelanford · 2019-06-07T20:26:22Z

@estroz Haha. I thought I heard the opposite based on the same premise. What I heard was "The separate branch for the original controller-runtime migration was a pain. Since the changes this time around are minimal relative to last time, a separate branch shouldn't be a big deal."

If we merge this to master, then we're either going to make a release on a non-stable version of controller-runtime, or we're going to be forced to wait until controller-runtime reaches a stable v0.2.0 release.

camilamacedo86 · 2019-06-07T20:26:47Z

Hi @estroz,

Could you add here the follow commit?

1ad0fef

And upgrade the following deps as well?

[[constraint]]
  name = "github.com/sirupsen/logrus"
  version = "1.4.2"

[[constraint]]
  name = "github.com/spf13/cobra"
  version = "0.0.4"

Also, I think you can use the Changelog and just update the commit number c5bdaee

Really tks for the help on it 👍

estroz · 2019-06-07T20:33:05Z

@joelanford very possible I heard incorrectly. I'll make a refactor branch like we did last time.

joelanford

/lgtm

Not sure how to handle the difference in version numbers in the CHANGELOG since #1612 was merged. So if those suggestions don't make sense, you can ignore them. Should we merge master into refactor/controller-runtime-v0.2.0?

…r-runtime-v0.2.0

openshift-ci-robot · 2019-07-02T22:38:40Z

New changes are detected. LGTM label has been removed.

hasbro17

LGTM

Just one comment on the removed replace directive for the prometheus-operator dependency in go.mod.

Update the underlying operator-sdk to v0.11.x. The new version contains version v0.2.0 which introduces a new feature to watch multiple namesapces. This is needed to implement #20. For more information see operator-framework/operator-sdk#1512.

openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 3, 2019

openshift-ci-robot requested review from fabianvf and jmrodri June 3, 2019 17:30

estroz mentioned this pull request Jun 6, 2019

Upgrade the version of the dependency controller-runtime from v0.1.10 to v0.2.0-beta.1 #1388

Closed

estroz commented Jun 6, 2019

View reviewed changes

openshift-ci-robot requested review from AlexNPavel, hasbro17, joelanford, lilic, shawn-hurley and theishshah June 6, 2019 00:41

joelanford reviewed Jun 7, 2019

View reviewed changes

camilamacedo86 reviewed Jun 7, 2019

View reviewed changes

Comment thread Gopkg.toml Outdated

camilamacedo86 reviewed Jun 7, 2019

View reviewed changes

Comment thread internal/pkg/scaffold/gopkgtoml_test.go

camilamacedo86 reviewed Jun 7, 2019

View reviewed changes

Comment thread internal/pkg/scaffold/gopkgtoml.go

estroz changed the title ~~[WIP] (for testing purposes only) bump to controller-runtime v0.2.0~~ deps: bump to controller-runtime v0.2.0, kubernetes-1.14.1, and helm v2.14.1 Jun 7, 2019

openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 7, 2019

estroz requested review from joelanford and removed request for joelanford June 10, 2019 16:53

openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jul 2, 2019

Eric Stroczynski added 3 commits July 2, 2019 13:44

internal/pkg/scaffold,Gopkg.toml: bump to v0.2.0-beta.3

7eb7446

CHANGELOG.md: bump to v0.2.0-beta.3

3d4a8d3

vendor/,Gopkg.lock: bump to v0.2.0-beta.3

f0f35cc

estroz force-pushed the bump-controller-runtime-v0.2.0 branch from 1b7b8d9 to f0f35cc Compare July 2, 2019 20:45

estroz mentioned this pull request Jul 2, 2019

'generate openapi' - CRD name and group are wrong #1608

Closed

joelanford approved these changes Jul 2, 2019

View reviewed changes

Comment thread CHANGELOG.md Outdated

Comment thread CHANGELOG.md Outdated

openshift-ci-robot assigned joelanford Jul 2, 2019

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 2, 2019

Merge branch 'refactor/controller-runtime-v0.2.0' into bump-controlle…

9775b8b

…r-runtime-v0.2.0

openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jul 2, 2019

hasbro17 reviewed Jul 2, 2019

View reviewed changes

Comment thread internal/pkg/scaffold/helm/go_mod.go

hasbro17 approved these changes Jul 2, 2019

View reviewed changes

estroz force-pushed the bump-controller-runtime-v0.2.0 branch from 5912ff4 to 8e6dd4c Compare July 3, 2019 17:43

bump prometheus-operator to v0.31.1

d9b89bb

estroz force-pushed the bump-controller-runtime-v0.2.0 branch from 8e6dd4c to d9b89bb Compare July 3, 2019 18:06

Eric Stroczynski added 3 commits July 3, 2019 12:22

remove deleted test file added back during merge

eb5d0d0

remove unused deps

bed5b00

add some changes not caught in prior merge

c182305

estroz merged commit fc3b764 into operator-framework:refactor/controller-runtime-v0.2.0 Jul 3, 2019

estroz deleted the bump-controller-runtime-v0.2.0 branch July 3, 2019 23:10

lilic mentioned this pull request Jul 4, 2019

Bump deps to version 1.14 openshift/cluster-network-operator#178

Closed

This was referenced Jul 16, 2019

Upgrade to operator-sdk v0.9.0 aerogear/unifiedpush-operator#45

Closed

Changelog of the Release 0.9.0 shows messing the info over the PR 1512 #1682

Closed

estroz mentioned this pull request Sep 4, 2019

bump controller-runtime/-tools to v0.2.0, helm to 2.14, kubernetes to 1.14 #1876

Merged

camilamacedo86 mentioned this pull request Oct 3, 2019

Add MultiNamespacedCacheBuilder option in the docs which was introduced with the #1512 and is valid just in the master branch. #2008

Closed

ricoberger mentioned this pull request Oct 27, 2019

Restrict the controller to a particular namespace ricoberger/vault-secrets-operator#20

Closed

ricoberger mentioned this pull request Oct 28, 2019

Update operator-sdk to version v0.11.x ricoberger/vault-secrets-operator#21

Merged

Conversation

estroz commented Jun 3, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

estroz Jun 6, 2019

Choose a reason for hiding this comment

Uh oh!

estroz commented Jun 6, 2019

Uh oh!

estroz commented Jun 6, 2019

Uh oh!

lilic commented Jun 7, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

joelanford commented Jun 7, 2019

Uh oh!

estroz commented Jun 7, 2019

Uh oh!

joelanford commented Jun 7, 2019

Uh oh!

camilamacedo86 commented Jun 7, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

estroz commented Jun 7, 2019

Uh oh!

Uh oh!

Uh oh!

joelanford left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

openshift-ci-robot commented Jul 2, 2019

Uh oh!

Uh oh!

hasbro17 left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

estroz commented Jun 3, 2019 •

edited

Loading

camilamacedo86 commented Jun 7, 2019 •

edited

Loading